Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #266 #746

Closed
wants to merge 6 commits into from
Closed

Closes #266 #746

wants to merge 6 commits into from

Conversation

da1rren
Copy link

@da1rren da1rren commented Sep 25, 2018 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Pull request implements a simple method that convert System.Net.Mail.MailMessages to SendGridMessages
  • It supports:
    • Headers
    • To, CC, BCC
    • Reply to
    • Subject & Body
  • The bodies content type is automatically determined if it is unspecified
  • Updated the test project to target .net 2.1 so we have the types to test against
  • Updated the build script to use the .net 2.1 sdk

@da1rren
Began implementation of #266
857129b 
* Added the extension method to sendgrid lib
* Added some basic tests
* Raised test project to .net core 2.1 (Need so I have the types to test with)
@da1rren
Added some documentation and renamed method to instead of get
18fb17d
@da1rren
* Added support for headers to mail message conversion
b40471f 
* Expanded tests
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 25, 2018
@SendGridDX
Copy link

SendGridDX commented Sep 25, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: hard fix is hard in difficulty labels Sep 28, 2018
@da1rren
Copy link
Author

da1rren commented Oct 17, 2018

@thinkingserious Have you had a chance to review?

@da1rren da1rren closed this Feb 19, 2019
@Mek7 Mek7 mentioned this pull request Nov 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a helper to convert MailMessage to SendGrid.Mail
3 participants
@da1rren @SendGridDX @thinkingserious